feat(connections): Support mssql-python driver.#5647
Open
walanguzzi wants to merge 9 commits into
Open
Conversation
|
|
DATETIMEOFFSET is natively supported by `mssql-python`. See "microsoft/mssql-python#213"
- Added a TODO re its removal as it should already be supported natively by `mssql-python`.
chore: Sync upstream `main`.
|
I'm interested in having this driver in the product because the existing driver does not work well with my VPN. I have a set of patches I use to do it, but, didn't submit them because I couldn't do it very cleanly. I can't comment on the PR itself. |
|
@walanguzzi thanks for the contribution! Are there any updates on this pending PR? Is there someone we can ping? |
Author
|
Thanks @RG-sw and @codykonior-hsi. We've been waiting for a review from one of the maintainers, however, it seems this branch is now out-of-date and needs rebasing against I will do this within the next few days and then try to @ someone from the team so hopefully it gains some traction🤞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Issue #5645 - support the official
mssql-pythondriver from Microsoft.The new driver implements PEP 249 interfaces and should work as a pluggable drop-in: https://pypi.org/project/mssql-python/
Motivation
The driver bundles a lightweight and high-performance binary layer replacing the platform's Driver Manager hence eliminating the need for system-level ODBC installations.
As per the
mssql-pythonoverview, additional benefits include:mssql-pythonis all that's needed)Code Changes
connect_mssql_pythonand moved the priorpyodbclogic toconnect_pyodbc.driverconfiguration support for"mssql-python"to relevant*ConnectionConfigclasses:MSSQLConnectionConfigAzureSQLConnectionConfigFabricConnectionConfigruffandpylance).Test Plan
All CI runs are successful.
The
fast-test,slow-testanddoc-testtargets are also passing (locally).However, there is one issue with the
test_state_sync:test_version_schematest case being "out of sync" and prompting for a migration when run locally - I have yet to resolve this.